Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 11418021: Revert 168079 - This CL ensures that favicons always (Closed)

Created:
8 years, 1 month ago by pkotwicz
Modified:
8 years, 1 month ago
Reviewers:
pkotwicz
CC:
chromium-reviews, nkostylev+watch_chromium.org, browser-components-watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 168079 - This CL ensures that favicons always 1) Stores a 1x representation in history 2) Returns a 1x representation upon calling FaviconService::GetFaviconImageForURL() such that the 1x favicon can be pushed to sync. BUG=160503 Test=Manual, see instructions below 1) Go to http://www.corp.google.com/~pkotwicz/favicon_small_big/test.html on an iOS device and bookmark it. On the iOS device, the favicon should be red. 2) On a windows device, make sure that the favicon which is received via sync is blue Review URL: https://chromiumcodereview.appspot.com/11360233 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -76 lines) Patch
M chrome/browser/chromeos/login/helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/favicon/favicon_service.h View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 7 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/favicon/favicon_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/favicon/favicon_util.cc View 2 chunks +1 line, -25 lines 0 comments Download
M ui/base/layout.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pkotwicz
8 years, 1 month ago (2012-11-16 00:07:23 UTC) #1
pkotwicz
8 years, 1 month ago (2012-11-16 00:08:18 UTC) #2
Reverting because, this misses adding 1x for non retina devices in the supported
scale factors list

Powered by Google App Engine
This is Rietveld 408576698