Issue 11418007: Android backend: tidy up the --suffix handling.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11418007: Android backend: tidy up the --suffix handling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 10 months ago by Torne

Modified:
3 years, 10 months ago

Reviewers:
Nico (mostly away until Oct 3)

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Android backend: tidy up the --suffix handling. Make --suffix .foo generate a makefile called GypAndroid.foo.mk, instead of GypAndroid.mk.foo. Committed: https://code.google.com/p/gyp/source/detail?r=1535

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pylib/gyp/generator/android.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results:

Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Torne

Just a trivial one. I need to use --suffix to handle generating makefiles for different ...

3 years, 10 months ago (2012-11-15 13:42:41 UTC) #1

Nico (mostly away until Oct 3)

lgtm This shall be the last change to this generator that I lgtm without testing ...

3 years, 10 months ago (2012-11-15 15:31:21 UTC) #2

Torne

3 years, 10 months ago (2012-11-15 15:44:24 UTC) #3

On 2012/11/15 15:31:21, Nico wrote:
> lgtm
> 
> This shall be the last change to this generator that I lgtm without testing
> infrastructure in place.

OK. I've been trying the tests locally in an AOSP tree and think I nearly have
it working, so I can look at the gyp bot in the next few days I hope.

Expand Messages | Collapse Messages