Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 11418007: Android backend: tidy up the --suffix handling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Torne
Modified:
3 years, 8 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android backend: tidy up the --suffix handling. Make --suffix .foo generate a makefile called GypAndroid.foo.mk, instead of GypAndroid.mk.foo. Committed: https://code.google.com/p/gyp/source/detail?r=1535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
Torne
Just a trivial one. I need to use --suffix to handle generating makefiles for different ...
3 years, 8 months ago (2012-11-15 13:42:41 UTC) #1
Nico (ooo until Aug 1)
lgtm This shall be the last change to this generator that I lgtm without testing ...
3 years, 8 months ago (2012-11-15 15:31:21 UTC) #2
Torne
3 years, 8 months ago (2012-11-15 15:44:24 UTC) #3
On 2012/11/15 15:31:21, Nico wrote:
> lgtm
> 
> This shall be the last change to this generator that I lgtm without testing
> infrastructure in place.

OK. I've been trying the tests locally in an AOSP tree and think I nearly have
it working, so I can look at the gyp bot in the next few days I hope.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 18aec74