Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: chrome/common_constants.gyp

Issue 11418005: Get a minimal unit_tests target building and running for iOS (Closed) Base URL: http://git.chromium.org/chromium/src.git@chrome-gyp-ios-support
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common_constants.gyp
diff --git a/chrome/common_constants.gyp b/chrome/common_constants.gyp
index e5f6d619a413615f1f1e73636568a7781e4a9452..4e3915818ad2afcd834e1cc9d5e188c70374a0d9 100644
--- a/chrome/common_constants.gyp
+++ b/chrome/common_constants.gyp
@@ -65,6 +65,15 @@
'../base/base.gyp:base',
'../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
],
+ 'target_conditions': [
+ ['OS=="ios"', {
+ # iOS needs chrome_paths_mac, which is excluded by filename rules;
+ # re-add it in target_conditionals so it's after that exclusion.
Nico 2012/11/15 18:01:33 Is there a file name rule for files that are used
stuartmorgan 2012/11/15 18:23:11 No. I spoke to Mark about this quite a while ago,
Nico 2012/11/15 18:27:22 It's ok, I was just curious.
+ 'sources/': [
+ ['include', '^common/chrome_paths_mac\\.mm$'],
+ ],
+ }],
+ ],
'conditions': [
['toolkit_uses_gtk == 1', {
'dependencies': ['../build/linux/system.gyp:gtk'],

Powered by Google App Engine
This is Rietveld 408576698