Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/tools/roll/build_v8.patch

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | testing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/roll/build_v8.patch
diff --git a/mojo/tools/roll/build_v8.patch b/mojo/tools/roll/build_v8.patch
index 5575f24cebd2669e8866115df7626dce20f4f04f..7f0083b4cd7e2abbb91e53bf85988bfdc8d5c865 100644
--- a/mojo/tools/roll/build_v8.patch
+++ b/mojo/tools/roll/build_v8.patch
@@ -1,13 +1,11 @@
diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni
-index db4ee4e..05b673b 100644
+index 8b5204c..aa2848c 100644
--- a/build/module_args/v8.gni
+++ b/build/module_args/v8.gni
-@@ -9,4 +9,7 @@ if (is_android) {
+@@ -9,5 +9,5 @@ if (is_android) {
# TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.
enable_correct_v8_arch = false
-v8_use_external_startup_data = !(is_chromeos || is_win)
-+# Many V8 users in mojo do not support external startup data for V8, so
-+# we disable it. If enabled, special care should be taken to ensure the
-+# appropriate startup data is correctly bundled for apps.
+v8_use_external_startup_data = false
+ v8_extra_library_files = []
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | testing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698