Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: base/trace_event/trace_event_argument.h

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event.h ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_argument.h
diff --git a/base/trace_event/trace_event_argument.h b/base/trace_event/trace_event_argument.h
index 78d37d4122947ce9eecccc7afc016eeafa9aceff..d86cfd1f82aecbb126688c83874f211dc0d16360 100644
--- a/base/trace_event/trace_event_argument.h
+++ b/base/trace_event/trace_event_argument.h
@@ -29,7 +29,7 @@ class BASE_EXPORT TracedValue : public ConvertableToTraceFormat {
void SetDouble(const char* name, double);
void SetBoolean(const char* name, bool value);
void SetString(const char* name, const std::string& value);
- void SetValue(const char* name, Value* value);
+ void SetValue(const char* name, scoped_ptr<Value> value);
void BeginDictionary(const char* name);
void BeginArray(const char* name);
@@ -49,7 +49,7 @@ class BASE_EXPORT TracedValue : public ConvertableToTraceFormat {
ListValue* GetCurrentArray();
scoped_ptr<base::Value> root_;
- std::vector<Value*> stack_;
+ std::vector<Value*> stack_; // Weak references.
DISALLOW_COPY_AND_ASSIGN(TracedValue);
};
« no previous file with comments | « base/trace_event/trace_event.h ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698