base/test/trace_event_analyzer_unittest.cc - Issue 1141793003: Update from https://crrev.com/329939

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_event_analyzer_unittest.cc

diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc

index 4bdb94121d9d07980a5d7a701685f10372ed31c1..cf85fd0963c45b4b1b11886a5eda2f541202c3a2 100644

--- a/base/test/trace_event_analyzer_unittest.cc

+++ b/base/test/trace_event_analyzer_unittest.cc

@@ -225,7 +225,7 @@ TEST_F(TraceEventAnalyzerTest, BooleanOperators) {

scoped_ptr<TraceAnalyzer>

analyzer(TraceAnalyzer::Create(output_.json_output));

- ASSERT_TRUE(!!analyzer.get());

+ ASSERT_TRUE(analyzer);

analyzer->SetIgnoreMetadataEvents(true);

TraceEventVector found;

« no previous file with comments | « base/test/launcher/test_results_tracker.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »