Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1141763004: Implement %TypedArray%.{lastI,i}ndexOf (Closed)

Created:
5 years, 7 months ago by dehrenberg
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement %TypedArray%.{lastI,i}ndexOf This patch adds the two TypedArray methods indexOf and lastIndexOf, which are similar to the methods on Arrays. Tests are ported from arrays as well. BUG=v8:3578 LOG=Y R=arv@chromium.org Committed: https://crrev.com/31fb50247497b5d681792e7707b8a739aee6c736 Patch from Daniel Ehrenberg <dehrenberg@chromium.org>;. Cr-Commit-Position: refs/heads/master@{#28495}

Patch Set 1 #

Patch Set 2 : minor style fix #

Total comments: 2

Patch Set 3 : cleanups #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -7 lines) Patch
M src/array.js View 1 2 3 4 5 chunks +26 lines, -7 lines 0 comments Download
M src/harmony-typedarray.js View 1 2 3 4 2 chunks +25 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typedarray-indexing.js View 1 2 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dehrenberg
5 years, 7 months ago (2015-05-18 23:38:15 UTC) #1
dehrenberg
Oops, I mailed this before reading the comments on the previous patch. I'll fix a ...
5 years, 7 months ago (2015-05-18 23:51:09 UTC) #2
dehrenberg
On 2015/05/18 23:51:09, dehrenberg wrote: > Oops, I mailed this before reading the comments on ...
5 years, 7 months ago (2015-05-19 00:16:22 UTC) #3
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1141763004/diff/20001/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1141763004/diff/20001/src/harmony-typedarray.js#newcode94 src/harmony-typedarray.js:94: // ES6 draft 05-18-15 section 22.2.3.13 At this ...
5 years, 7 months ago (2015-05-19 15:10:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141763004/40001
5 years, 7 months ago (2015-05-19 16:13:58 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/31fb50247497b5d681792e7707b8a739aee6c736 Cr-Commit-Position: refs/heads/master@{#28495}
5 years, 7 months ago (2015-05-20 01:09:41 UTC) #8
adamk
5 years, 7 months ago (2015-05-20 01:09:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
31fb50247497b5d681792e7707b8a739aee6c736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698