[Mobile] Upstream fix for yandex search engine

[Mobile] Upstream fix for yandex search engine

Use a different path for template URL for yandex search on mobile to avoid an
extra redirection. Mobile should use http://yandex.ru/touchsearch?text=${query}
or http://yandex.ru/padsearch?text=${query} depending on the device form factor
instead of http://yandex.ru/yandsearch?text=${query}.

The issue was reported by yandex and fixed in downstream iOS fork. Upstream
it now that the code is componentized.

TEST=Set your locale to Russian, launch Chrome for iOS, select Yandex as the
search engine, type a query in the omnibox to do a search, check that you're
sent to /touchsearch directly, not via /yandsearch first.

BUG=b/7024148

Committed: https://crrev.com/0ea1107bf2c1a0532d1c10a3666cafb9047abbb6
Cr-Commit-Position: refs/heads/master@{#330500}

[sdefresne, 2015-05-13 14:27:54]

sdefresne@chromium.org changed reviewers:
+ pkasting@chromium.org

[sdefresne, 2015-05-13 14:27:54]

Please take a look.

This is upstreaming a fix we had for a long time in iOS downstream fork (cue the
bug pointing to old internal bug system).

[sdefresne, 2015-05-13 14:28:17]

qsr: FYI

[Peter Kasting, 2015-05-13 22:56:55]

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/p...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/p...
components/search_engines/prepopulated_engines.json:33: "kCurrentDataVersion":
82
You need to increment this.

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:109: const char
kYandexSearchPathParameter[] = "yandex:searchPath";
I'm not a fan of the ton of constants we have up here that are only ever used
once, since it's not clear that their scope is actually very narrow; and the
constant names add nothing to the actual string values.

Can you inline this into the code that uses it below?  Added bonus for inlining
any other constants up here that are in a similar situation.

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:695: #if defined(OS_ANDROID) ||
defined(OS_IOS)
Is OS_ANDROID correct here for tablets running Android?

[sdefresne, 2015-05-18 12:35:45]

Thank you for the review. PTAL.

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/p...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/p...
components/search_engines/prepopulated_engines.json:33: "kCurrentDataVersion":
82
On 2015/05/13 22:56:55, Peter Kasting wrote:
> You need to increment this.

Done.

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:109: const char
kYandexSearchPathParameter[] = "yandex:searchPath";
On 2015/05/13 22:56:55, Peter Kasting wrote:
> I'm not a fan of the ton of constants we have up here that are only ever used
> once, since it's not clear that their scope is actually very narrow; and the
> constant names add nothing to the actual string values.
> 
> Can you inline this into the code that uses it below?  Added bonus for
inlining
> any other constants up here that are in a similar situation.

Done. Followup CL https://codereview.chromium.org/1146673002/ to inline the
other constants (and get the bonus points).

https://codereview.chromium.org/1141743003/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:695: #if defined(OS_ANDROID) ||
defined(OS_IOS)
On 2015/05/13 22:56:55, Peter Kasting wrote:
> Is OS_ANDROID correct here for tablets running Android?

I've tested and tablet are redirected to "padsearch" when using either of
"yandsearch" or "touchsearch" (both on android and iOS) so I've updated the CL
to check for the device form factor to decide which tarm to use.

[Peter Kasting, 2015-05-18 18:25:58]

LGTM

https://codereview.chromium.org/1141743003/diff/20001/components/search_engin...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1141743003/diff/20001/components/search_engin...
components/search_engines/template_url.cc:691: #if defined(OS_ANDROID) ||
defined(OS_IOS)
Maybe instead of the #ifs here we should be using the form factor all the time. 
Use "yandsearch" for DESKTOP, "touchsearch" for PHONE, and "padsearch" for
TABLET.

[sdefresne, 2015-05-19 09:09:20]

Thank you for the review.

https://codereview.chromium.org/1141743003/diff/20001/components/search_engin...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1141743003/diff/20001/components/search_engin...
components/search_engines/template_url.cc:691: #if defined(OS_ANDROID) ||
defined(OS_IOS)
On 2015/05/18 18:25:58, Peter Kasting wrote:
> Maybe instead of the #ifs here we should be using the form factor all the
time. 
> Use "yandsearch" for DESKTOP, "touchsearch" for PHONE, and "padsearch" for
> TABLET.

Done.

[sdefresne, 2015-05-19 09:09:33]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-05-19 09:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1141743003/#ps40001
(title: "Always switch on form factor when substituting {yandex:searchPath}")

[commit-bot: I haz the power, 2015-05-19 09:09:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141743003/40001

[commit-bot: I haz the power, 2015-05-19 10:03:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-19 10:05:28]

Patchset 3 (id:??) landed as
https://crrev.com/0ea1107bf2c1a0532d1c10a3666cafb9047abbb6
Cr-Commit-Position: refs/heads/master@{#330500}