GN: Do not set rpath on android executable.

GN: Do not set rpath on android executable.

Android executable do not support rpath, and the executable is
displaying a warning on launch if it is present. The warning is :
unused DT entry: type 0xf arg 0xa35

R=dpranke@chromium.org,brettw@chromium.org

Committed: https://crrev.com/90acb0f2b53bfa3ae632f9391a8f8f6e5dcde9eb
Cr-Commit-Position: refs/heads/master@{#329663}

[Dirk Pranke, 2015-05-13 15:07:49]

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn#n...
build/config/gcc/BUILD.gn:34: }
Can you rewrite this so that the code reads

if (is_android) {
  ...
} else {
  ...
}

?

[qsr, 2015-05-13 15:13:02]

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn#n...
build/config/gcc/BUILD.gn:34: }
On 2015/05/13 15:07:49, Dirk Pranke wrote:
> Can you rewrite this so that the code reads
> 
> if (is_android) {
>   ...
> } else {
>   ...
> }
> 
> ?

Yes, but the 2 parts of the if have nothing to do one with the other. If you
still prefer it with an else, I'll change it.

[Dirk Pranke, 2015-05-13 15:34:59]

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn#n...
build/config/gcc/BUILD.gn:34: }
On 2015/05/13 15:13:02, qsr wrote:
> On 2015/05/13 15:07:49, Dirk Pranke wrote:
> > Can you rewrite this so that the code reads
> > 
> > if (is_android) {
> >   ...
> > } else {
> >   ...
> > }
> > 
> > ?
> 
> Yes, but the 2 parts of the if have nothing to do one with the other. If you
> still prefer it with an else, I'll change it.

I understand your logic, but I think to someone who hasn't really stared at the
code, my way is faster to comprehend. My answer would be probably be different
if you hadn't changed line 37.

[qsr, 2015-05-13 16:44:58]

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/1141723002/diff/1/build/config/gcc/BUILD.gn#n...
build/config/gcc/BUILD.gn:34: }
On 2015/05/13 15:34:59, Dirk Pranke wrote:
> On 2015/05/13 15:13:02, qsr wrote:
> > On 2015/05/13 15:07:49, Dirk Pranke wrote:
> > > Can you rewrite this so that the code reads
> > > 
> > > if (is_android) {
> > >   ...
> > > } else {
> > >   ...
> > > }
> > > 
> > > ?
> > 
> > Yes, but the 2 parts of the if have nothing to do one with the other. If you
> > still prefer it with an else, I'll change it.
> 
> I understand your logic, but I think to someone who hasn't really stared at
the
> code, my way is faster to comprehend. My answer would be probably be different
> if you hadn't changed line 37.

I see. Makes sense. Changed.

[Dirk Pranke, 2015-05-13 16:56:31]

lgtm

[qsr, 2015-05-13 16:57:02]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2015-05-13 16:57:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141723002/20001

[commit-bot: I haz the power, 2015-05-13 17:17:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 17:19:05]

Patchset 2 (id:??) landed as
https://crrev.com/90acb0f2b53bfa3ae632f9391a8f8f6e5dcde9eb
Cr-Commit-Position: refs/heads/master@{#329663}