Query the network delegate for cookies even if there is no cookie monster

net/url_request/url_request_http_job.cc

Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 4f57a31295057567bf7f5cd53b3ab9f36b609447..76ece0c7bcdbca9907431642628257b6e4e21493 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -515,7 +515,7 @@ void URLRequestHttpJob::AddCookieHeaderAndStart() {
           base::Bind(&URLRequestHttpJob::CheckCookiePolicyAndLoad,
                      weak_factory_.GetWeakPtr()));
     } else {
-      DoLoadCookies();
+      CheckCookiePolicyAndLoad(CookieList());

[droger, 2012/11/23 16:00:12]

I pass an empty list as 'default' argument here, as it's not possible to compute
the actual list using only the CookieStore API.

Note: browsing the code, it seems that no implementation of the NetworkDelegate
actually use the |cookie_list| argument. If it's true, maybe we could remove it?
If we do this, we could even remove the call to
cookie_monster->GetAllCookiesForURLAsync() (line 513 above) altogether!

[erikwright (departed), 2012/11/27 05:17:17]

ChromeNetworkDelegate passes the list to TabSpecificContentSettings, which
stores them for reporting cookies that have been sent/blocked to the user.

[cbentzel, 2012/11/28 14:36:42]

Out of curiosity: is the Cookie header already supplied at this point for
non-CookieMonster based requests? If so, should this parse the results and pass
it in as a CookieList?

[droger, 2012/11/28 14:47:44]

Looking at the code, the headers are set a bit after, in OnCookiesLoaded, which
is triggered by DoLoadCookies().

I understand why it is desirable to unify the behavior, but also note that on
iOS I don't currently need the actual list of cookies, because the cookie
setting is "all or nothing". 

[erikwright (departed), 2012/11/30 16:43:52]

The problem is that the CookieList is cookies with all metadata, whereas the
cookie header is just the name-value pairs of cookies that matched the request.
It's pig vs. sausage.

     }
   } else {
     DoStartTransaction();