Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/ui/ash/volume_controller_chromeos.cc

Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: forlanding3 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/event_rewriter_unittest.cc ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/volume_controller_chromeos.cc
diff --git a/chrome/browser/ui/ash/volume_controller_chromeos.cc b/chrome/browser/ui/ash/volume_controller_chromeos.cc
index f44b8b401f592e7742453e565a31fa5951663c45..d90aa6062398b9dd3c10b22c1f06b10b2802977f 100644
--- a/chrome/browser/ui/ash/volume_controller_chromeos.cc
+++ b/chrome/browser/ui/ash/volume_controller_chromeos.cc
@@ -17,7 +17,7 @@ const double kStepPercentage = 4.0;
} // namespace
bool VolumeController::HandleVolumeMute(const ui::Accelerator& accelerator) {
- if (accelerator.key_code() == ui::VKEY_F8)
+ if (accelerator.key_code() == ui::VKEY_VOLUME_MUTE)
content::RecordAction(content::UserMetricsAction("Accel_VolumeMute_F8"));
chromeos::AudioHandler* audio_handler = chromeos::AudioHandler::GetInstance();
@@ -32,7 +32,7 @@ bool VolumeController::HandleVolumeMute(const ui::Accelerator& accelerator) {
}
bool VolumeController::HandleVolumeDown(const ui::Accelerator& accelerator) {
- if (accelerator.key_code() == ui::VKEY_F9)
+ if (accelerator.key_code() == ui::VKEY_VOLUME_DOWN)
content::RecordAction(content::UserMetricsAction("Accel_VolumeDown_F9"));
chromeos::AudioHandler* audio_handler = chromeos::AudioHandler::GetInstance();
@@ -47,7 +47,7 @@ bool VolumeController::HandleVolumeDown(const ui::Accelerator& accelerator) {
}
bool VolumeController::HandleVolumeUp(const ui::Accelerator& accelerator) {
- if (accelerator.key_code() == ui::VKEY_F10)
+ if (accelerator.key_code() == ui::VKEY_VOLUME_UP)
content::RecordAction(content::UserMetricsAction("Accel_VolumeUp_F10"));
chromeos::AudioHandler* audio_handler = chromeos::AudioHandler::GetInstance();
« no previous file with comments | « chrome/browser/ui/ash/event_rewriter_unittest.cc ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698