chrome/browser/ui/ash/brightness_controller_chromeos.cc - Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/brightness_controller_chromeos.cc

Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: forlanding3 Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/brightness_controller_chromeos.cc

diff --git a/chrome/browser/ui/ash/brightness_controller_chromeos.cc b/chrome/browser/ui/ash/brightness_controller_chromeos.cc

index 36e97626b66b7be586303dc0140b46288895ab21..4c984d702db91751f5acdd520e7d83f2be6676e7 100644

--- a/chrome/browser/ui/ash/brightness_controller_chromeos.cc

+++ b/chrome/browser/ui/ash/brightness_controller_chromeos.cc

@@ -11,7 +11,7 @@

bool BrightnessController::HandleBrightnessDown(

const ui::Accelerator& accelerator) {

- if (accelerator.key_code() == ui::VKEY_F6)

+ if (accelerator.key_code() == ui::VKEY_BRIGHTNESS_DOWN)

content::RecordAction(

content::UserMetricsAction("Accel_BrightnessDown_F6"));

@@ -22,7 +22,7 @@ bool BrightnessController::HandleBrightnessDown(

bool BrightnessController::HandleBrightnessUp(

const ui::Accelerator& accelerator) {

- if (accelerator.key_code() == ui::VKEY_F7)

+ if (accelerator.key_code() == ui::VKEY_BRIGHTNESS_UP)

content::RecordAction(content::UserMetricsAction("Accel_BrightnessUp_F7"));

chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->

« no previous file with comments | « ash/system/chromeos/keyboard_brightness_controller.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | no next file with comments »