chrome/browser/ui/views/frame/browser_view.cc - Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Helper method do keysym mapping Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/event_rewriter.cc ('K') | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 2002b396ca16a0a4c71bba8a4e95eb8c9b760b13..024cbbe7178cc5957ee922675d8ecb63df56165a 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2635,7 +2635,7 @@ void BrowserView::UpdateAcceleratorMetrics(

case IDC_BACK:

if (key_code == ui::VKEY_BACK)

content::RecordAction(UserMetricsAction("Accel_Back_Backspace"));

- else if (key_code == ui::VKEY_F1)

+ else if (key_code == ui::VKEY_BROWSER_BACK)

content::RecordAction(UserMetricsAction("Accel_Back_F1"));

else if (key_code == ui::VKEY_LEFT)

content::RecordAction(UserMetricsAction("Accel_Back_Left"));

@@ -2643,7 +2643,7 @@ void BrowserView::UpdateAcceleratorMetrics(

case IDC_FORWARD:

if (key_code == ui::VKEY_BACK)

content::RecordAction(UserMetricsAction("Accel_Forward_Backspace"));

- else if (key_code == ui::VKEY_F2)

+ else if (key_code == ui::VKEY_BROWSER_FORWARD)

content::RecordAction(UserMetricsAction("Accel_Forward_F2"));

else if (key_code == ui::VKEY_RIGHT)

content::RecordAction(UserMetricsAction("Accel_Forward_Right"));

@@ -2652,11 +2652,11 @@ void BrowserView::UpdateAcceleratorMetrics(

case IDC_RELOAD_IGNORING_CACHE:

if (key_code == ui::VKEY_R)

content::RecordAction(UserMetricsAction("Accel_Reload_R"));

- else if (key_code == ui::VKEY_F3)

+ else if (key_code == ui::VKEY_BROWSER_REFRESH)

content::RecordAction(UserMetricsAction("Accel_Reload_F3"));

break;

case IDC_FULLSCREEN:

- if (key_code == ui::VKEY_F4)

+ if (key_code == ui::VKEY_MEDIA_LAUNCH_APP2)

content::RecordAction(UserMetricsAction("Accel_Fullscreen_F4"));

break;

case IDC_FOCUS_LOCATION: