ash/system/chromeos/keyboard_brightness_controller.cc - Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/keyboard_brightness_controller.cc

Issue 11417144: Use rewriting to make ChromeOS keyboard F<number> keys produce extended keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: chromeboxkeyboard Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/accelerators/accelerator_table.cc ('K') | « ash/accelerators/accelerator_table.cc ('k') | chrome/browser/ui/ash/brightness_controller_chromeos.cc » ('j') | chrome/browser/ui/ash/event_rewriter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/chromeos/keyboard_brightness_controller.cc

diff --git a/ash/system/chromeos/keyboard_brightness_controller.cc b/ash/system/chromeos/keyboard_brightness_controller.cc

index f3f34c14717da8733451daf698d8f76dca6022be..bad8d09cde438ab61e4cf30224494aefed3c0521 100644

--- a/ash/system/chromeos/keyboard_brightness_controller.cc

+++ b/ash/system/chromeos/keyboard_brightness_controller.cc

@@ -15,7 +15,7 @@ namespace ash {

bool KeyboardBrightnessController::HandleKeyboardBrightnessDown(

const ui::Accelerator& accelerator) {

- if (accelerator.key_code() == ui::VKEY_F6) {

+ if (accelerator.key_code() == ui::VKEY_BRIGHTNESS_DOWN) {

Shell::GetInstance()->delegate()->RecordUserMetricsAction(

UMA_ACCEL_KEYBOARD_BRIGHTNESS_DOWN_F6);

}

@@ -27,7 +27,7 @@ bool KeyboardBrightnessController::HandleKeyboardBrightnessDown(

bool KeyboardBrightnessController::HandleKeyboardBrightnessUp(

const ui::Accelerator& accelerator) {

- if (accelerator.key_code() == ui::VKEY_F7) {

+ if (accelerator.key_code() == ui::VKEY_BRIGHTNESS_UP) {

Shell::GetInstance()->delegate()->RecordUserMetricsAction(

UMA_ACCEL_KEYBOARD_BRIGHTNESS_UP_F7);

}