Issue 11417140: Censor .caller if it is a strict function instead of throwing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417140: Censor .caller if it is a strict function instead of throwing. (Closed)

Created:
8 years, 1 month ago by rossberg

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev, adamk, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Censor .caller if it is a strict function instead of throwing. For details, see: http://www.mail-archive.com/es-discuss@mozilla.org/msg19322.html https://bugs.ecmascript.org/show_bug.cgi?id=310 R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13049

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -25 lines)			Patch
	M	src/accessors.cc	View		2 chunks	+8 lines, -14 lines	0 comments	Download
	M	test/mjsunit/strict-mode.js	View		2 chunks	+36 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 1 month ago (2012-11-22 16:27:46 UTC) #2

LGTM. As discussed offline, it might make sense to put this behind some
--es52_poison_pill flag for now.

Also I like the fact that Test262 contains 97 test cases checking this, and all
of them still pass with the new semantic. That is very nice!

Expand Messages | Collapse Messages