build/android/cpufeatures.gypi - Issue 11417114: Android: fix cpu_features for WebView build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/cpufeatures.gypi

Issue 11417114: Android: fix cpu_features for WebView build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Depend on the Android NDK's cpu feature detection. The WebView build is part

	6 # of the system and the library already exists; for the normal build there is a

	7 # gyp file in the checked-in NDK to build it.

	8 {

	9 'conditions': [

	10 ['android_build_type != 0', {

	11 'libraries': [

	12 'cpufeatures.a'

	13 ],

	14 }, {

	15 'dependencies': [

	16 '<(android_ndk_root)/android_tools_ndk.gyp:cpu_features',

	17 ],

	18 }],
	joth 2012/11/21 17:43:20 just to check - neither these set the include path just to check - neither these set the include path. Do we get cpufeatures.h "for free" from whatever NDK include path we happen to be using? If so there could be a version mismatch between that, and the system built version of the static lib. (?) wjia(left Chromium) 2012/11/21 18:39:40 For branch using '<(android_ndk_root)/android_tool Show quoted text On 2012/11/21 17:43:20, joth wrote: > just to check - neither these set the include path. Do we get cpufeatures.h "for > free" from whatever NDK include path we happen to be using? If so there could be > a version mismatch between that, and the system built version of the static lib. > (?) For branch using '<(android_ndk_root)/android_tools_ndk.gyp:cpu_features', the path to third_party/android_tools/ndk/sources/android/cpufeatures/cpufeatures.h has been included in include path. And it uses third_party/android_tools/ndk/sources/android/cpufeatures/cpufeatures.c to make libcpu_features.a. refer to http://git.chromium.org/gitweb/?p=android_tools.git;a=blob_plain;f=ndk/androi... . Please let me know if this could be a problem.
	19 ],

	20 }

OLD	NEW

« no previous file with comments | « no previous file | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »