Issue 11417109: google_apis: Inject the base WAPI server URL to GDataWapiService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417109: google_apis: Inject the base WAPI server URL to GDataWapiService (Closed)

Created:
8 years, 1 month ago by satorux1

Modified:
8 years, 1 month ago

Reviewers:
kinuko, hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Inject the base WAPI server URL to GDataWapiService This will make it easy to write tests using the test server running locally. BUG=161903 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168990

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -9 lines)			Patch
M	chrome/browser/chromeos/drive/drive_system_service.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/drive_file_sync_client.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chrome/browser/sync_file_system lgtm

Expand Messages | Collapse Messages