google_apis: Get rid of gdata_wapi_url_util namespace

google_apis: Get rid of gdata_wapi_url_util namespace

Move functions in  gdata_wapi_url_util namespace to
GDataWapiUrlGenerator class as static functions.
No change in behaviors.

BUG=161903
TEST=none
TBR=thestig@chromium.org
# for .gypi changes

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168984

[hashimoto, 2012-11-21 03:37:44]

FYI: Try server cannot apply your patch if the branch's "merge" entry in
src/.git/config is different from "refs/heads/master"

https://codereview.chromium.org/11417108/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_url_generator.h (right):

https://codereview.chromium.org/11417108/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_url_generator.h:24: static const char
kBaseUrlForProduction[];
How about having static methods which return GURL instead of these constants?
It seems all users of these constants are making GURL from them immediately.

[satorux1, 2012-11-21 04:05:38]

https://codereview.chromium.org/11417108/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_url_generator.h (right):

https://codereview.chromium.org/11417108/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_url_generator.h:24: static const char
kBaseUrlForProduction[];
On 2012/11/21 03:37:44, hashimoto wrote:
> How about having static methods which return GURL instead of these constants?
> It seems all users of these constants are making GURL from them immediately.

I thought about it but went with constants. Functions are a bit more complex
than constants. :)

[hashimoto, 2012-11-21 04:09:32]

lgtm

[Lei Zhang, 2012-11-26 21:09:26]

lgtm