Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 11417098: Added libjpeg and zlib to SDK (Closed)

Created:
8 years, 1 month ago by noelallen1
Modified:
8 years ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Added libjpeg and zlib to SDK These libraries are already in Chrome's third party, so we just add a library.dsc to build them. They will eventually need to be converted to GYP file along with the rest of the NaCl SDK gyp work. R=binji@chromium.org BUG=162141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171031

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated include and experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -2 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/library.mk View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 1 chunk +1 line, -1 line 0 comments Download
A native_client_sdk/src/libraries/libjpeg/library.dsc View 1 1 chunk +87 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/zlib/library.dsc View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
noelallen1
ptal
8 years ago (2012-11-26 23:13:22 UTC) #1
binji
https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode577 native_client_sdk/src/build_tools/build_sdk.py:577: # 'libpng', remove https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/libraries/libjpeg/library.dsc File native_client_sdk/src/libraries/libjpeg/library.dsc (right): https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/libraries/libjpeg/library.dsc#newcode34 native_client_sdk/src/libraries/libjpeg/library.dsc:34: ...
8 years ago (2012-11-26 23:23:20 UTC) #2
binji
We also might want them to be experimental for now, until we have some tests.
8 years ago (2012-11-26 23:23:58 UTC) #3
noelallen1
Added experimental https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/11417098/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode577 native_client_sdk/src/build_tools/build_sdk.py:577: # 'libpng', On 2012/11/26 23:23:20, binji wrote: ...
8 years ago (2012-11-27 23:52:24 UTC) #4
binji
lgtm
8 years ago (2012-11-28 22:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/11417098/10002
8 years ago (2012-12-03 21:09:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 22:48:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/11417098/10002
8 years ago (2012-12-04 18:04:24 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-04 20:10:14 UTC) #9
Message was sent while issue was closed.
Change committed as 171031

Powered by Google App Engine
This is Rietveld 408576698