Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: runtime/vm/exceptions.cc

Issue 11417058: Revert "Remove NullPointerException." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.h ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index 479ad64437e836f83aa2a82f8492a484359eebfb..fc2e2c9e70d620e99d57f29d413b280a2e1ca2e5 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -144,7 +144,7 @@ static void ThrowExceptionHelper(const Instance& incoming_exception,
Instance& exception = Instance::Handle(incoming_exception.raw());
if (exception.IsNull()) {
GrowableArray<const Object*> arguments;
- exception ^= Exceptions::Create(Exceptions::kNullThrown, arguments);
+ exception ^= Exceptions::Create(Exceptions::kNullPointer, arguments);
}
uword handler_pc = 0;
uword handler_sp = 0;
@@ -427,14 +427,18 @@ RawObject* Exceptions::Create(
library = Library::CoreLibrary();
class_name = Symbols::New("InternalError");
break;
- case kNullThrown:
+ case kNullPointer:
library = Library::CoreLibrary();
- class_name = Symbols::New("NullThrownError");
+ class_name = Symbols::New("NullPointerException");
break;
case kIllegalJSRegExp:
library = Library::CoreLibrary();
class_name = Symbols::New("IllegalJSRegExpException");
break;
+ case kArgumentError:
+ library = Library::CoreLibrary();
+ class_name = Symbols::New("ArgumentError");
+ break;
case kIsolateSpawn:
library = Library::IsolateLibrary();
class_name = Symbols::New("IsolateSpawnException");
« no previous file with comments | « runtime/vm/exceptions.h ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698