Chromium changes for static linking ffmpeg

media/base/media.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media.h"
 
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/path_service.h"
 #include "base/synchronization/lock.h"
 #include "build/build_config.h"
 #include "media/base/yuv_convert.h"
 
+#if !defined(MEDIA_DISABLE_FFMPEG)
+#include "media/ffmpeg/ffmpeg_common.h"
+#endif
+
 namespace media {
 
-namespace internal {
-// Platform specific initialization method.
-extern bool InitializeMediaLibraryInternal(const base::FilePath& module_dir);
-}  // namespace internal
-
 // Media must only be initialized once, so use a LazyInstance to ensure this.
 class MediaInitializer {
  public:
-  bool Initialize(const base::FilePath& module_dir) {
+  void Initialize() {

[DaleCurtis, 2015/06/02 18:21:07]

No need for an Initilize() method and a lock anymore, this can be condensed into
the constructor and initialized_ deleted.

[chcunningham, 2015/06/03 01:14:16]

Done.

     base::AutoLock auto_lock(lock_);
-    if (!tried_initialize_) {
-      tried_initialize_ = true;
-      initialized_ = internal::InitializeMediaLibraryInternal(module_dir);
+    if (!initialized_) {
+#if !defined(MEDIA_DISABLE_FFMPEG)
+  // Disable logging as it interferes with layout tests.

[DaleCurtis, 2015/06/02 18:21:07]

Indent is wrong for these, it should be as if the #if wasn't there.

[chcunningham, 2015/06/03 01:14:16]

Done.

+  av_log_set_level(AV_LOG_QUIET);
+
+#if defined(ALLOCATOR_SHIM)
+  // Remove allocation limit from ffmpeg, so calls go down to shim layer.
+  av_max_alloc(0);
+#endif  // defined(ALLOCATOR_SHIM)
+
+#endif  // !defined(MEDIA_DISABLE_FFMPEG)
+
+      initialized_ = true;
     }
-    return initialized_;
-  }
-
-  bool IsInitialized() {
-    base::AutoLock auto_lock(lock_);
-    return initialized_;
   }
 
  private:
   friend struct base::DefaultLazyInstanceTraits<MediaInitializer>;
 
-  MediaInitializer()
-      : initialized_(false),
-        tried_initialize_(false) {
+  MediaInitializer() : initialized_(false) {
     // Perform initialization of libraries which require runtime CPU detection.
     InitializeCPUSpecificYUVConversions();
   }
 
   ~MediaInitializer() {
     NOTREACHED() << "MediaInitializer should be leaky!";
   }
 
   base::Lock lock_;
   bool initialized_;
-  bool tried_initialize_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaInitializer);
 };
 
 static base::LazyInstance<MediaInitializer>::Leaky g_media_library =
     LAZY_INSTANCE_INITIALIZER;
 
-bool InitializeMediaLibrary(const base::FilePath& module_dir) {
-  return g_media_library.Get().Initialize(module_dir);
-}
-
-void InitializeMediaLibraryForTesting() {
-  base::FilePath module_dir;
-  CHECK(PathService::Get(base::DIR_EXE, &module_dir));
-  CHECK(g_media_library.Get().Initialize(module_dir));
-}
-
-bool IsMediaLibraryInitialized() {
-  return g_media_library.Get().IsInitialized();
+void InitializeMediaLibrary() {
+  g_media_library.Get().Initialize();
 }
 
 void InitializeCPUSpecificMediaFeatures() {
   // Force initialization of the media initializer, but don't call Initialize().
   g_media_library.Get();
 }
 
 }  // namespace media