Issue 11417029: Drastically reduce the number of created strings in d8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417029: Drastically reduce the number of created strings in d8. (Closed)

Created:
8 years, 1 month ago by Sven Panne

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Drastically reduce the number of created strings in d8. This also reduces the number of TLS accesses, so it is a double-win. We have 230k less TLS accesses while running Octane now, so we are down to 23% now compared to the start of these TLS-related CLs. Introduced a tiny helper function for throwing on the way. Committed: https://code.google.com/p/v8/source/detail?r=12991

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -88 lines)			Patch
	M	src/d8.cc	View	1	24 chunks	+113 lines, -88 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/11417029/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/11417029/diff/1/src/d8.cc#newcode94 src/d8.cc:94: FOR_EACH_SYMBOL(DEFINE_SYMBOL) Add "#undef DEFINE_SYMBOL"

8 years, 1 month ago (2012-11-16 13:25:31 UTC) #2

Sven Panne

8 years, 1 month ago (2012-11-16 13:28:35 UTC) #3

Landing...

https://codereview.chromium.org/11417029/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/11417029/diff/1/src/d8.cc#newcode94
src/d8.cc:94: FOR_EACH_SYMBOL(DEFINE_SYMBOL)
On 2012/11/16 13:25:31, Michael Starzinger wrote:
> Add "#undef DEFINE_SYMBOL"

Done.

Expand Messages | Collapse Messages