Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: runtime/bin/process_patch.dart

Issue 11417028: Include command in ProcessException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index ff99345f4a2b4c75e82e628c36b5bef6f2e6f6ed..4d383b6d5e01188eb08824391c6bb939708b21ee 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -157,8 +157,11 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {
_out.close();
_err.close();
_exitHandler.close();
+ var arguments = Strings.join(_arguments, ' ');
completer.completeException(
- new ProcessException(status._errorMessage, status._errorCode));
+ new ProcessException('$_path $arguments',
Søren Gjesse 2012/11/16 12:45:02 We could also place path and arguments on the Proc
Mads Ager (google) 2012/11/16 13:00:30 Done.
+ status._errorMessage,
+ status._errorCode));
return;
}
_started = true;
@@ -245,7 +248,8 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {
void set onExit(void callback(int exitCode)) {
if (_ended) {
- throw new ProcessException("Process killed");
+ var arguments = Strings.join(_arguments, ' ');
+ throw new ProcessException("$_path $arguments", "Process killed");
}
_onExit = callback;
}
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698