Reland r167487: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

chrome/browser/printing/print_preview_tab_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/printing/print_view_manager.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
+#include "content/public/browser/plugin_service.h"
 #include "content/public/common/url_constants.h"
+#include "webkit/plugins/npapi/mock_plugin_list.h"
 
 // Test crashes on Aura due to initiator tab's native view having no parent.
 // http://crbug.com/104284
 #if defined(USE_AURA)
 #define MAYBE_GetOrCreatePreviewTab DISABLED_GetOrCreatePreviewTab
 #define MAYBE_MultiplePreviewTabs DISABLED_MultiplePreviewTabs
 #define MAYBE_ClearInitiatorTabDetails DISABLED_ClearInitiatorTabDetails
 #else
 #define MAYBE_GetOrCreatePreviewTab GetOrCreatePreviewTab
 #define MAYBE_MultiplePreviewTabs MultiplePreviewTabs
 #define MAYBE_ClearInitiatorTabDetails ClearInitiatorTabDetails
 #endif
 
 class PrintPreviewTabControllerUnitTest : public BrowserWithTestWindowTest {
  public:
   PrintPreviewTabControllerUnitTest() {}

[Peter Kasting, 2012/11/15 18:53:50]

Nit: While here, can you de-inline these member functions?  This particular
class is tiny so it's not too hard to read as-is, but we try to move people away
from having class members inlined just because they're in a .cc file (especially
for things like virtual functions).

[Bernhard Bauer, 2012/11/18 19:15:26]

Moved it into a base class.

   virtual ~PrintPreviewTabControllerUnitTest() {}
 
  protected:
   virtual void SetUp() OVERRIDE {
     BrowserWithTestWindowTest::SetUp();
 
+    // The PluginService will be destroyed at the end of the test (due to the
+    // ShadowingAtExitManager in our base class).
+    content::PluginService::GetInstance()->SetPluginListForTesting(
+        &plugin_list_);
+
     profile()->GetPrefs()->SetBoolean(prefs::kPrintPreviewDisabled, false);
   }
+
+ private:
+  webkit::npapi::MockPluginList plugin_list_;

[Peter Kasting, 2012/11/15 18:53:50]

Nit: DISALLOW_COPY_AND_ASSIGN too

[Bernhard Bauer, 2012/11/15 23:26:30]

Gahh, I always forget these. Note to self: write a clang plug-in that checks
this.

 };
 
 // Create/Get a preview tab for initiator tab.
 TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) {
   // Lets start with one window with one tab.
   EXPECT_EQ(1u, BrowserList::size());
   EXPECT_EQ(0, browser()->tab_count());
   chrome::NewTab(browser());
   EXPECT_EQ(1, browser()->tab_count());
 
@@ skipping 113 matching lines @@
   tab_controller->EraseInitiatorTabInfo(preview_tab);
 
   // Get the print preview tab for initiator tab.
   TabContents* new_preview_tab =
       tab_controller->GetOrCreatePreviewTab(initiator_tab);
 
   // New preview tab is created.
   EXPECT_EQ(1, browser()->tab_count());
   EXPECT_NE(new_preview_tab, preview_tab);
 }