Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1141663003: fixes #185, track const ctor dependencies, plus a static field fix (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #185, track const ctor dependencies, plus a static field fix R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1efa05add7f946e35e70edaa506ee18cbd899d6e

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -27 lines) Patch
M lib/runtime/dart/convert.js View 3 chunks +16 lines, -16 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 7 chunks +21 lines, -10 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/fieldtest.js View 2 chunks +12 lines, -0 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/fieldtest.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-19 21:12:31 UTC) #2
vsm
lgtm
5 years, 7 months ago (2015-05-20 14:57:31 UTC) #3
Jennifer Messerly
5 years, 7 months ago (2015-05-20 16:19:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1efa05add7f946e35e70edaa506ee18cbd899d6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698