media/webm/webm_tracks_parser.cc - Issue 11416367: Add Opus decode wrapper to media.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/webm/webm_tracks_parser.cc

Issue 11416367: Add Opus decode wrapper to media. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased (changed machines) Address most comments. Added TODO for Opus buffering question. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/webm/webm_tracks_parser.cc

diff --git a/media/webm/webm_tracks_parser.cc b/media/webm/webm_tracks_parser.cc

index 8a8864db05e20dece16c600045523b296f536abb..02a41ef2b820b99f17278ed2df3c363795b90c9a 100644

--- a/media/webm/webm_tracks_parser.cc

+++ b/media/webm/webm_tracks_parser.cc

@@ -138,7 +138,8 @@ bool WebMTracksParser::OnBinary(int id, const uint8* data, int size) {

}

bool WebMTracksParser::OnString(int id, const std::string& str) {

- if (id == kWebMIdCodecID && str != "A_VORBIS" && str != "V_VP8") {

+ if (id == kWebMIdCodecID &&

+ str != "A_VORBIS" && str != "A_OPUS" && str != "V_VP8") {

scherkus (not reviewing) 2012/12/14 21:13:34 will this make it work with media source?

Tom Finegan 2012/12/14 23:19:52 Media source is not working with opus.

MEDIA_LOG(log_cb_) << "Unexpected CodecID " << str;

return false;

}