media/filters/chunk_demuxer.cc - Issue 11416367: Add Opus decode wrapper to media.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/chunk_demuxer.cc

Issue 11416367: Add Opus decode wrapper to media. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased (changed machines) Address most comments. Added TODO for Opus buffering question. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/chunk_demuxer.cc

diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc

index c24528177205f062772182f12f58d951e3766237..cba46ee28c4e42e40a4803ea13ba630920ae7658 100644

--- a/media/filters/chunk_demuxer.cc

+++ b/media/filters/chunk_demuxer.cc

@@ -41,15 +41,18 @@ struct SupportedTypeInfo {

static const CodecInfo kVP8CodecInfo = { "vp8", DemuxerStream::VIDEO };

static const CodecInfo kVorbisCodecInfo = { "vorbis", DemuxerStream::AUDIO };

+static const CodecInfo kOpusCodecInfo = { "opus", DemuxerStream::AUDIO };

static const CodecInfo* kVideoWebMCodecs[] = {

&kVP8CodecInfo,

&kVorbisCodecInfo,

+ &kOpusCodecInfo,

NULL

};

static const CodecInfo* kAudioWebMCodecs[] = {

&kVorbisCodecInfo,

+ &kOpusCodecInfo,

scherkus (not reviewing) 2012/12/14 21:13:34 does this add support for opus to chunk demuxer /

Tom Finegan 2012/12/14 23:19:52 It does not work; removed changes in this file.

NULL

};