media/base/audio_decoder_config.h - Issue 11416367: Add Opus decode wrapper to media.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_decoder_config.h

Issue 11416367: Add Opus decode wrapper to media. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased (changed machines) Address most comments. Added TODO for Opus buffering question. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_decoder_config.h

diff --git a/media/base/audio_decoder_config.h b/media/base/audio_decoder_config.h

index ce62eb85a1f6389d3fdac77866eeba19200e1279..76d40b43d5beb062195a13dabe563b8444f1a688 100644

--- a/media/base/audio_decoder_config.h

+++ b/media/base/audio_decoder_config.h

@@ -30,12 +30,14 @@ enum AudioCodec {

kCodecGSM_MS,

kCodecPCM_S16BE,

kCodecPCM_S24BE,

+ // Additional codecs for all platforms.

scherkus (not reviewing) 2012/12/14 21:13:34 nit: this comment will likely become invalid at so

Tom Finegan 2012/12/14 23:19:52 Done.

+ kCodecOpus,

// DO NOT ADD RANDOM AUDIO CODECS!

// The only acceptable time to add a new codec is if there is production code

// that uses said codec in the same CL.

- kAudioCodecMax = kCodecPCM_S24BE // Must equal the last "real" codec above.

+ kAudioCodecMax = kCodecOpus // Must equal the last "real" codec above.

};

// TODO(dalecurtis): FFmpeg API uses |bytes_per_channel| instead of