Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: vm/symbols.h

Issue 11416356: Add dump_symbol_stats to dump symbol table stats at the end of a test run (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/isolate.cc ('k') | vm/symbols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.h
===================================================================
--- vm/symbols.h (revision 15988)
+++ vm/symbols.h (working copy)
@@ -226,10 +226,12 @@
static bool IsPredefinedHandle(uword address);
+ static void DumpStats();
+
private:
enum {
- kInitialVMIsolateSymtabSize = ((kMaxId + 15) & -16),
- kInitialSymtabSize = 256
+ kInitialVMIsolateSymtabSize = 512,
+ kInitialSymtabSize = 2048
};
// Helper functions to create a symbol given a string or set of characters.
@@ -275,6 +277,11 @@
// stored in the vm isolate.
static VMHandles predefined_handles_;
+ // Statistics used to measure the efficiency of the symbol table.
+ static const intptr_t kMaxCollisionBuckets = 10;
+ static intptr_t num_of_grows_;
+ static intptr_t collision_count_[kMaxCollisionBuckets];
+
#define DECLARE_SYMBOL_HANDLE(symbol) \
static String* symbol##_handle_;
PREDEFINED_SYMBOL_HANDLES_LIST(DECLARE_SYMBOL_HANDLE)
« no previous file with comments | « vm/isolate.cc ('k') | vm/symbols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698