Adding java implementation for Geolocation

net/android/gurl_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "net/quic/crypto/crypto_protocol.h"

[willchan no longer on Chromium, 2012/12/13 22:44:29]

Hehe, I don't think branching is really what you want here :) Unless you want
their rev history shared.

[Kristian Monsen, 2012/12/13 23:32:32]

I was wondering about this as well, I think it is just git trying to be clever.
Not sure what I can do about it.

+#ifndef NET_ANDROID_GURL_UTILS_H_
+#define NET_ANDROID_GURL_UTILS_H_
+
+#include <jni.h>

[willchan no longer on Chromium, 2012/12/13 22:44:29]

Can we just forward declare JNIEnv?

[Kristian Monsen, 2012/12/13 23:32:32]

It doesn't actually need to be (read can't I think) forward declared since it is
magic included. This makes this do nothing since it is always included. Do you
think it is better without this include?

[willchan no longer on Chromium, 2012/12/13 23:41:09]

Magic included? I don't know what that means. Do you mean the build process is
doing it already?

Feel free to ignore my comment if this is a special Android build thing. My
comment is just from the style guide which encourages reducing header file
dependencies via forward declarations.

 
 namespace net {
 
-CryptoHandshakeMessage::CryptoHandshakeMessage() {}
-CryptoHandshakeMessage::~CryptoHandshakeMessage() {}
+bool RegisterGURLUtils(JNIEnv* env);
 
-}  // namespace net
+}  // net namespace
+
+#endif  // NET_ANDROID_GURL_UTILS_H_