Issue 11416345: Fix for tab re-attach on windows desktop aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416345: Fix for tab re-attach on windows desktop aura (Closed)

Created:
8 years ago by cpu_(ooo_6.6-7.5)

Modified:
8 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix for tab re-attach on windows desktop aura When draggin a window from the tab to re-attach the tab to another window it didn't work because the windows enumeration was not ignoring the window that was being moved (aka itself). BUG=128578 TEST= windows aura desktop, drag tab out and try to re-attach. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171082

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/tabs/dock_info_win.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages