Omnibox should accept and navigate URLs dropped using drag and drop.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 761 matching lines @@
   const string16 text = textfield_->text();
   GURL url;
   bool write_url;
   model()->AdjustTextForCopy(selection_range.start(), selected_text == text,
       &selected_text, &url, &write_url);
   data->SetString(selected_text);
   if (write_url)
     data->SetURL(url, selected_text);
 }
 
+void OmniboxViewViews::AppendDropFormats(
+    int* formats,
+    std::set<ui::OSExchangeData::CustomFormat>* custom_formats) {
+  *formats = *formats | ui::OSExchangeData::URL;
+}
+
+int OmniboxViewViews::OnDrop(const ui::OSExchangeData& data) {
+  if (data.HasURL()) {

[sky, 2012/12/03 23:46:40]

Shouldn't this match the windows implementation? Can we refactor the two to
share?

[varunjain, 2012/12/04 18:44:13]

the windows implementation handles all drops in OmniboxViewWin, whereas, here,
we only handle URL drops while simple text drops are handled (rightfuly so) in
NativeTextfieldViews. There are about 5 lines of code that are common between
OmniboxViewViews and OmniboeViewWin that I can refactor to OmniboxView. IMHO it
is not worth doing that also because gtk has its own handling on drop and does
not look like can be merged (it does not even use OSExchangeData). It seems more
consistent to do this separately for Views and Win as well.

+    GURL url;
+    string16 title;
+    string16 text;
+    data.GetURLAndTitle(&url, &title);
+    if (url.is_valid())
+      text = UTF8ToUTF16(url.spec());
+    if (model()->CanPasteAndGo(text)) {
+      model()->PasteAndGo(text);
+      return ui::DragDropTypes::DRAG_COPY;
+    }
+  }
+  return ui::DragDropTypes::DRAG_NONE;
+}
+
 void OmniboxViewViews::UpdateContextMenu(ui::SimpleMenuModel* menu_contents) {
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 
   if (chrome::search::IsInstantExtendedAPIEnabled(
           location_bar_view_->profile())) {
     int copy_position = menu_contents->GetIndexOfCommandId(IDS_APP_COPY);
@@ skipping 142 matching lines @@
   if (!text.empty()) {
     // Record this paste, so we can do different behavior.
     model()->on_paste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted into the
     // text box.
     text_before_change_.clear();
     textfield_->ReplaceSelection(text);
   }
 }