Issue 11416324: Revert changes to have ExtensionService notify ThemeService directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416324: Revert changes to have ExtensionService notify ThemeService directly (Closed)

Created:
8 years ago by akalin

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, James Simonsen

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert changes to have ExtensionService notify ThemeService directly This reverts r159875 and r170640. It cause a performance regression that's not easy to fix, as detailed in the bug. BUG=163706 TBR=asargent@chromium.org,erg@chromium.org,pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170824

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -121 lines)			Patch
M	chrome/browser/extensions/extension_install_ui_browsertest.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_default.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	5 chunks	+5 lines, -15 lines	0 comments	Download
M	chrome/browser/themes/theme_service.h	View	7 chunks	+20 lines, -17 lines	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View	6 chunks	+56 lines, -45 lines	0 comments	Download
M	chrome/browser/themes/theme_service_factory.h	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/themes/theme_service_factory.cc	View	1 chunk	+10 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	3 chunks	+2 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

8 years ago (2012-12-03 21:20:46 UTC) #2

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11416324/1