Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 11416291: Fix win32 build breakage (Closed)

Created:
8 years ago by Cutch
Modified:
8 years ago
Reviewers:
srdjan, cshapiro
CC:
cshapiro, srdjan
Visibility:
Public.

Description

Fix win32 build breakage Change signature of OS::AlignedAllocate from using intptr_t to size_t Committed: https://code.google.com/p/dart/source/detail?r=15603

Patch Set 1 #

Patch Set 2 : Fix win32 breakage #

Patch Set 3 : Fix Mac breakage too. #

Patch Set 4 : Add TODO to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M runtime/vm/os_macos.cc View 1 2 3 1 chunk +6 lines, -7 lines 0 comments Download
M runtime/vm/os_test.cc View 1 2 3 1 chunk +20 lines, -9 lines 0 comments Download
M runtime/vm/os_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
8 years ago (2012-11-30 21:15:34 UTC) #1
srdjan
lgtm
8 years ago (2012-11-30 21:31:32 UTC) #2
cshapiro
lgtm
8 years ago (2012-11-30 21:31:48 UTC) #3
cshapiro
8 years ago (2012-11-30 21:35:16 UTC) #4
lgtm

still lgtm

Powered by Google App Engine
This is Rietveld 408576698