Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11416257: Revert "Add @JSName annotation for native fields and methods." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 /** Enable the 'JS' helper for a library if needed. */ 486 /** Enable the 'JS' helper for a library if needed. */
487 void maybeEnableJSHelper(LibraryElement library) { 487 void maybeEnableJSHelper(LibraryElement library) {
488 String libraryName = library.uri.toString(); 488 String libraryName = library.uri.toString();
489 if (library.entryCompilationUnit.script.name.contains( 489 if (library.entryCompilationUnit.script.name.contains(
490 'dart/tests/compiler/dart2js_native') 490 'dart/tests/compiler/dart2js_native')
491 || libraryName == 'dart:mirrors' 491 || libraryName == 'dart:mirrors'
492 || libraryName == 'dart:isolate' 492 || libraryName == 'dart:isolate'
493 || libraryName == 'dart:math' 493 || libraryName == 'dart:math'
494 || libraryName == 'dart:html' 494 || libraryName == 'dart:html'
495 || libraryName == 'dart:svg') { 495 || libraryName == 'dart:svg') {
496 if (libraryName == 'dart:html' || 496 if (libraryName == 'dart:html' || libraryName == 'dart:mirrors') {
497 libraryName == 'dart:svg' || 497 // dart:html needs access to convertDartClosureToJS.
498 libraryName == 'dart:mirrors') {
499 // dart:html and dart:svg need access to convertDartClosureToJS and
500 // annotation classes.
501 // dart:mirrors needs access to the Primitives class. 498 // dart:mirrors needs access to the Primitives class.
502 importHelperLibrary(library); 499 importHelperLibrary(library);
503 } 500 }
504 library.addToScope(findHelper(const SourceString('JS')), this); 501 library.addToScope(findHelper(const SourceString('JS')), this);
505 Element jsIndexingBehaviorInterface = 502 Element jsIndexingBehaviorInterface =
506 findHelper(const SourceString('JavaScriptIndexingBehavior')); 503 findHelper(const SourceString('JavaScriptIndexingBehavior'));
507 if (jsIndexingBehaviorInterface != null) { 504 if (jsIndexingBehaviorInterface != null) {
508 library.addToScope(jsIndexingBehaviorInterface, this); 505 library.addToScope(jsIndexingBehaviorInterface, this);
509 } 506 }
510 } 507 }
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
941 // TODO(johnniwinther): Use [spannable] and [message] to provide better 938 // TODO(johnniwinther): Use [spannable] and [message] to provide better
942 // information on assertion errors. 939 // information on assertion errors.
943 if (condition is Function){ 940 if (condition is Function){
944 condition = condition(); 941 condition = condition();
945 } 942 }
946 if (spannable == null || !condition) { 943 if (spannable == null || !condition) {
947 throw new SpannableAssertionFailure(spannable, message); 944 throw new SpannableAssertionFailure(spannable, message);
948 } 945 }
949 return true; 946 return true;
950 } 947 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/apiimpl.dart ('k') | sdk/lib/_internal/compiler/implementation/dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698