Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 11416255: remove htmlescape from sdk (Closed)

Created:
8 years ago by dgrove
Modified:
8 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

(I hadn't deleted an old changelist which had intermediate changes. Please ignore the changes except in the last changeset) Remove htmlescape from sdk. TBR=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=15611

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add gen_snapshot to SDK. #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/create_sdk.py View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrove
8 years ago (2012-11-29 01:25:19 UTC) #1
dgrove
On 2012/11/29 01:25:19, dgrove wrote: BUG=6007
8 years ago (2012-11-29 01:35:10 UTC) #2
ahe
I don't see any tests of this. Also, shouldn't we have a script in sdk/bin, ...
8 years ago (2012-11-29 05:40:12 UTC) #3
dgrove
On 2012/11/29 05:40:12, ahe wrote: > I don't see any tests of this. Also, shouldn't ...
8 years ago (2012-11-29 05:42:03 UTC) #4
dgrove
Add gen_snapshot to SDK.
8 years ago (2012-11-29 06:16:26 UTC) #5
dgrove
On 2012/11/29 06:16:26, dgrove wrote: > Add gen_snapshot to SDK. Actually, I see no tests ...
8 years ago (2012-11-29 06:23:54 UTC) #6
kasperl
DBC https://codereview.chromium.org/11416255/diff/7001/sdk/bin/gen_snapshot File sdk/bin/gen_snapshot (right): https://codereview.chromium.org/11416255/diff/7001/sdk/bin/gen_snapshot#newcode22 sdk/bin/gen_snapshot:22: exec "$BIN_DIR"/gen_snapshot "$@" Am I the only one ...
8 years ago (2012-11-29 06:59:01 UTC) #7
dgrove
8 years ago (2012-11-30 23:24:14 UTC) #8
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698