Issue 11416252: dbus: Add comments about object ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416252: dbus: Add comments about object ownership (Closed)

Created:
8 years ago by satorux1

Modified:
8 years ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, Seigo Nonaka

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

dbus: Add comments about object ownership BUG=163231 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170117

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -14 lines)			Patch
	M	dbus/exported_object.h	View		1 chunk	+21 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

While reviewing your patch, I needed to check how ownership is handled in ExportedObject. Hope ...

8 years ago (2012-11-28 23:32:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/11416252/1

8 years ago (2012-11-28 23:49:21 UTC) #3

commit-bot: I haz the power

8 years ago (2012-11-29 00:58:34 UTC) #4

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages