Desktop aura: Continue threading context through views.

ui/views/test/views_test_base.cc

Index: ui/views/test/views_test_base.cc
diff --git a/ui/views/test/views_test_base.cc b/ui/views/test/views_test_base.cc
index 3d3fe6482413544159d1b522ad8745c3217c2848..ac0b49797bec6b6ead3e55755997ed0ef0638f0d 100644
--- a/ui/views/test/views_test_base.cc
+++ b/ui/views/test/views_test_base.cc
@@ -9,6 +9,7 @@
 
 #if defined(USE_AURA)
 #include "ui/aura/env.h"
+#include "ui/aura/root_window.h"
 #include "ui/aura/test/aura_test_helper.h"
 #endif
 
@@ -59,4 +60,14 @@ void ViewsTestBase::RunPendingMessages() {
   run_loop.RunUntilIdle();
 }
 
+Widget::InitParams ViewsTestBase::CreateParams(
+    Widget::InitParams::Type type) {

[Ben Goodger (Google), 2012/11/29 22:16:20]

rather than adding this method, can you instead have this class tell the
TestViewsDelegate the context and have it implement CreateNativeWidget()?

[Elliot Glaysher, 2012/11/29 22:46:29]

That's moving where the global state is. I'd like it gone.

So currently, scottmg made it so that a context window is passed around as part
of the InitParams and I think this is the right design choice: the widget
creator is who has the information about where the widget should be created. I
eventually want to add a CHECK to NativeWidgetAura::InitParams to ensure that
either a parent, parent_widget or context has been given because we need some
handle to a aura::RootWindow.

Modifying the TestViewsDelegate, so that it is created on each test and creates
a special NativeWidgetAura, doesn't feel correct because it would be another
divergence from what's being tested since additional data usually isn't passed
in to NativeWidget subclasses at construction time. (I suppose we could move the
context to the NativeWidgetDelegate, but that doesn't seem strictly better.)

We could modify the ViewsDelegate::CreateNativeWidget() interface so that it
also took a context parameter, but that feels more like threading aura specific
context through cross platform code than the way I did it, where everything aura
specific has been centralized here.

+  Widget::InitParams params(type);
+  params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+#if defined(USE_AURA)
+  params.context = aura_test_helper_->root_window();
+#endif
+  return params;
+}
+
 }  // namespace views