Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: runtime/lib/growable_array.dart

Issue 11416240: Address Ivan's comments. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Fix typos Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/byte_array.dart ('k') | runtime/vm/intrinsifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/growable_array.dart
diff --git a/runtime/lib/growable_array.dart b/runtime/lib/growable_array.dart
index 7929f73fce471f0feca5c1dbfe5147ababfdd492..bda1fc9bd7514e4fd5821689211af6114e398c63 100644
--- a/runtime/lib/growable_array.dart
+++ b/runtime/lib/growable_array.dart
@@ -172,7 +172,9 @@ class _GrowableObjectArray<T> implements List<T> {
// Collection interface.
- bool contains(T element) => Collections.contains(this, element);
+ bool contains(T element) {
+ return Collections.contains(this, element);
+ }
void forEach(f(T element)) {
// TODO(srdjan): Use Collections.forEach(this, f);
@@ -182,13 +184,17 @@ class _GrowableObjectArray<T> implements List<T> {
}
}
- Iterable mappedBy(f(T element)) => new MappedIterable<T, dynamic>(this, f);
+ Iterable mappedBy(f(T element)) {
+ return new MappedIterable<T, dynamic>(this, f);
+ }
reduce(initialValue, combine(previousValue, T element)) {
return Collections.reduce(this, initialValue, combine);
}
- Iterable<T> where(bool f(T element)) => new WhereIterable<T>(this, f);
+ Iterable<T> where(bool f(T element)) {
+ return new WhereIterable<T>(this, f);
+ }
bool every(bool f(T element)) {
return Collections.every(this, f);
@@ -214,7 +220,9 @@ class _GrowableObjectArray<T> implements List<T> {
return Collections.collectionToString(this);
}
- Iterator<T> get iterator => new SequenceIterator<T>(this);
+ Iterator<T> get iterator {
+ return new SequenceIterator<T>(this);
+ }
List<T> toList() {
return new List<T>.from(this);
« no previous file with comments | « runtime/lib/byte_array.dart ('k') | runtime/vm/intrinsifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698