runtime/lib/byte_array.dart - Issue 11416240: Address Ivan's comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/byte_array.dart

Issue 11416240: Address Ivan's comments. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Fix typos Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/byte_array.dart

diff --git a/runtime/lib/byte_array.dart b/runtime/lib/byte_array.dart

index cfdcf1bb7a52cfae472692c274c57f25b176ed83..211c3bd519274119c267a2815f2e0d9c2bcf8492 100644

--- a/runtime/lib/byte_array.dart

+++ b/runtime/lib/byte_array.dart

@@ -1616,6 +1616,9 @@ class _ByteArrayView implements ByteArray {

}

+// TODO(floitsch): extending the collection adds extra cost (because of type

+// parameters). Consider copying the functions from Collection into this class

+// and just implementing Collection<int>.

class _ByteArrayViewBase extends Collection<int> {

num operator[](int index);

« no previous file with comments | « runtime/lib/array.dart ('k') | runtime/lib/growable_array.dart » ('j') | no next file with comments »