Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/child_process_security_policy_unittest.cc

Issue 11416218: Merge 168692 - Apply missing kParentDirectory check (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1312/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/child_process_security_policy_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_security_policy_unittest.cc
===================================================================
--- content/browser/child_process_security_policy_unittest.cc (revision 169793)
+++ content/browser/child_process_security_policy_unittest.cc (working copy)
@@ -347,100 +347,142 @@
}
TEST_F(ChildProcessSecurityPolicyTest, FilePermissions) {
+ FilePath granted_file = FilePath(FILE_PATH_LITERAL("/home/joe"));
+ FilePath sibling_file = FilePath(FILE_PATH_LITERAL("/home/bob"));
+ FilePath child_file = FilePath(FILE_PATH_LITERAL("/home/joe/file"));
+ FilePath parent_file = FilePath(FILE_PATH_LITERAL("/home"));
+ FilePath parent_slash_file = FilePath(FILE_PATH_LITERAL("/home/"));
+ FilePath child_traversal1 = FilePath(
+ FILE_PATH_LITERAL("/home/joe/././file"));
+ FilePath child_traversal2 = FilePath(
+ FILE_PATH_LITERAL("/home/joe/file/../otherfile"));
+ FilePath evil_traversal1 = FilePath(
+ FILE_PATH_LITERAL("/home/joe/../../etc/passwd"));
+ FilePath evil_traversal2 = FilePath(
+ FILE_PATH_LITERAL("/home/joe/./.././../etc/passwd"));
+ FilePath self_traversal = FilePath(
+ FILE_PATH_LITERAL("/home/joe/../joe/file"));
+
ChildProcessSecurityPolicyImpl* p =
ChildProcessSecurityPolicyImpl::GetInstance();
// Grant permissions for a file.
p->Add(kRendererID);
- FilePath file = FilePath(FILE_PATH_LITERAL("/etc/passwd"));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- p->GrantPermissionsForFile(kRendererID, file,
+ p->GrantPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_OPEN_TRUNCATED |
base::PLATFORM_FILE_READ |
base::PLATFORM_FILE_WRITE);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_OPEN_TRUNCATED |
base::PLATFORM_FILE_READ |
base::PLATFORM_FILE_WRITE));
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_CREATE));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_CREATE |
base::PLATFORM_FILE_OPEN_TRUNCATED |
base::PLATFORM_FILE_READ |
base::PLATFORM_FILE_WRITE));
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, sibling_file,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, parent_file,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, child_file,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, child_traversal1,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, child_traversal2,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, evil_traversal1,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, evil_traversal2,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
+ // CPSP doesn't allow this case for the sake of simplicity.
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, self_traversal,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ));
p->Remove(kRendererID);
// Grant permissions for the directory the file is in.
p->Add(kRendererID);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- p->GrantPermissionsForFile(kRendererID, FilePath(FILE_PATH_LITERAL("/etc")),
+ p->GrantPermissionsForFile(kRendererID, parent_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_READ |
base::PLATFORM_FILE_WRITE));
p->Remove(kRendererID);
// Grant permissions for the directory the file is in (with trailing '/').
p->Add(kRendererID);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- p->GrantPermissionsForFile(kRendererID, FilePath(FILE_PATH_LITERAL("/etc/")),
+ p->GrantPermissionsForFile(kRendererID, parent_slash_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_READ |
base::PLATFORM_FILE_WRITE));
// Grant permissions for the file (should overwrite the permissions granted
// for the directory).
- p->GrantPermissionsForFile(kRendererID, file, base::PLATFORM_FILE_TEMPORARY);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ p->GrantPermissionsForFile(kRendererID, granted_file,
+ base::PLATFORM_FILE_TEMPORARY);
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN));
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_TEMPORARY));
// Revoke all permissions for the file (it should inherit its permissions
// from the directory again).
- p->RevokeAllPermissionsForFile(kRendererID, file);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ p->RevokeAllPermissionsForFile(kRendererID, granted_file);
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_TEMPORARY));
p->Remove(kRendererID);
// Grant file permissions for the file to main thread renderer process,
// make sure its worker thread renderer process inherits those.
p->Add(kRendererID);
- p->GrantPermissionsForFile(kRendererID, file, base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
+ p->GrantPermissionsForFile(kRendererID, granted_file,
+ base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_READ);
+ EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, granted_file,
base::PLATFORM_FILE_WRITE));
p->AddWorker(kWorkerRendererID, kRendererID);
- EXPECT_TRUE(p->HasPermissionsForFile(kWorkerRendererID, file,
+ EXPECT_TRUE(p->HasPermissionsForFile(kWorkerRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kWorkerRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kWorkerRendererID, granted_file,
base::PLATFORM_FILE_WRITE));
p->Remove(kRendererID);
- EXPECT_FALSE(p->HasPermissionsForFile(kWorkerRendererID, file,
+ EXPECT_FALSE(p->HasPermissionsForFile(kWorkerRendererID, granted_file,
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ));
p->Remove(kWorkerRendererID);
« no previous file with comments | « content/browser/child_process_security_policy_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698