Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3137)

Unified Diff: chrome/browser/ui/browser.cc

Issue 11416187: Commit instant loader when the instant page navigates away from instant URL. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removing content/* changes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_tab.cc ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 709debdb4ac5f52ecc2bc1b260e785295ec4529a..270c15f82997c1051fdb3fe55c34ab3972db56e0 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1324,6 +1324,11 @@ void Browser::MaybeUpdateBookmarkBarStateForInstantPreview(
WebContents* Browser::OpenURLFromTab(WebContents* source,
const OpenURLParams& params) {
+ // Notify instant about the navigation. This needs to happen before so that
+ // instant can commit if required.
+ if (instant_controller_)
sky 2012/12/07 22:01:46 Does this really do what you want? Seems like you
Shishir 2012/12/08 00:14:54 Ok I got this wrong. The change does not belong h
+ instant_controller_->AboutToOpenURL(source, params.url);
+
chrome::NavigateParams nav_params(this, params.url, params.transition);
nav_params.source_contents = source;
nav_params.referrer = params.referrer;
« no previous file with comments | « chrome/browser/instant/instant_tab.cc ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698