Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11416187: Commit instant loader when the instant page navigates away from instant URL. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Minor spelling fix. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e4e4e6d7ccd0b3881dd0b5398fbb1d93ae68bea5..785e48544ca8501b5e09f6bdc458abbee5250113 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1560,6 +1560,9 @@ WebContents* WebContentsImpl::OpenURL(const OpenURLParams& params) {
if (!delegate_)
return NULL;
+ FOR_EACH_OBSERVER(WebContentsObserver, observers_,
+ AboutToOpenURL(params.url));
jam 2012/12/07 06:18:15 who's the WebContentsDelegate that gets called rig
Shishir 2012/12/07 21:01:25 We would like to get this call before the new WebC
jam 2012/12/07 21:21:02 maybe I wasn't clear. I'm not talking about changi
+
WebContents* new_contents = delegate_->OpenURLFromTab(this, params);
// Notify observers.
FOR_EACH_OBSERVER(WebContentsObserver, observers_,

Powered by Google App Engine
This is Rietveld 408576698