Commit instant loader when the instant page navigates away from instant URL.

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 1306 matching lines @@
       bookmark_bar_state_ == BookmarkBar::SHOW) {
     UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_INSTANT_PREVIEW_STATE);
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, content::WebContentsDelegate implementation:
 
 WebContents* Browser::OpenURLFromTab(WebContents* source,
                                      const OpenURLParams& params) {
+  // Notify instant about the navigation. This needs to happen before so that
+  // instant can commit if required.
+  if (instant_controller_)

[sky, 2012/12/07 22:01:46]

Does this really do what you want? Seems like you want
WebContentsObserver::NavigateToPendingEntry

[Shishir, 2012/12/08 00:14:54]

Ok I got this  wrong. The change does not belong here but in the
InstantLoader::WebContentsDelegate which is the delegate for the InstantPage and
not the browser. I think this change should make it clear why we need to make
the change in OpenURLFromTab. 

+    instant_controller_->AboutToOpenURL(source, params.url);
+
   chrome::NavigateParams nav_params(this, params.url, params.transition);
   nav_params.source_contents = source;
   nav_params.referrer = params.referrer;
   nav_params.extra_headers = params.extra_headers;
   nav_params.disposition = params.disposition;
   nav_params.tabstrip_add_types = TabStripModel::ADD_NONE;
   nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW;
   nav_params.user_gesture = true;
   nav_params.override_encoding = params.override_encoding;
   nav_params.is_renderer_initiated = params.is_renderer_initiated;
@@ skipping 1071 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }