Issue 11416179: Move chrome/common/favicon_url.(cc|h) into content/

Issue 11416179: Move chrome/common/favicon_url.(cc|h) into content/ (Closed)

Created:
8 years ago by Cait (Slow)

Modified:
8 years ago

Reviewers:
jam

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, cbentzel+watch_chromium.org, sadrul, ben+watch_chromium.org, tburkard+watch_chromium.org, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, mmenke, Jói

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move chrome/common/favicon_url.(cc|h) into content/ BUG=160995

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -94 lines)			Patch
M	chrome/browser/favicon/favicon_download_helper.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/favicon/favicon_download_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/favicon/favicon_download_helper_delegate.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_handler.h	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/favicon/favicon_handler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/favicon/favicon_handler_unittest.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/prerender/prerender_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_render_view_host_observer.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_render_view_host_observer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_favicon_loader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/metro_pin_tab_helper_win.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/common/favicon_url.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/common/favicon_url.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/common/icon_messages.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/favicon_helper.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/favicon_helper.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	content/public/common/favicon_url.h	View	2 chunks	+7 lines, -3 lines	0 comments	Download
A +	content/public/common/favicon_url.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Cait (Slow)

8 years ago (2012-11-26 23:29:33 UTC) #1

Hi John,

PTAL. This CL moves chrome/common/favicon_url.(cc|h) into content/public/common/
in preparation for moving the remaining favicon-downloading code into the
content namespace. 

All other changes are namespace changes (FaviconURL -> content::FaviconURL) and
path updates.

Thanks!

Expand Messages | Collapse Messages