Clean up ScopedVectorTest's LifeCycleObject.

Clean up ScopedVectorTest's LifeCycleObject.

The scoped_ptr<LifeCycleObject> was unncessary and confusing. The LifeCycleWatcher safely owns its LifeCycleObject and deletes it. The scoped_ptr made things a bit confusing even, since the only reason we weren't getting a double delete was because the scoped_ptr had an (ever so) slightly narrower scope than watcher.

Making the LifeCycleObject mostly private should encourage future callers not to add scary aliases. 

R=willchan@chromium.org
BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171058

[gavinp, 2012-11-24 13:44:59]

Will,

I cam across this while I was looking at ScopedVector. It's a minor change, so I
split it off, but it was subtle for me to understand why that scoped_ptr was
necessary, and then why it wasn't causing a double delete.

1. It was not necessary.

2. It didn't cause a double delete because when the scoped_ptr fell out of
scope, the LifeCycleObject deletion would clear the watcher, just as if a
ScopedVector had deleted the LifeCycleObject. But while it's clear a
LifeCycleWatcher should have scoped enclosing the ScopedVector, that was less
obvious here. I think it's clearer without the scoped_ptr.

While I was here, I switched some static_cast to implicit_cast. I firmly believe
that where implicit_cast works, it should be used.

Apologies for the multiple redundant issues being created; "git cl upload" was
malfunctioning.

[gavinp, 2012-11-24 14:27:18]

I made one last upload that makes the LifeCycleObject much more private,
guarding against this happening again.

https://codereview.chromium.org/11416166/diff/12001/base/memory/scoped_vector...
File base/memory/scoped_vector_unittest.cc (right):

https://codereview.chromium.org/11416166/diff/12001/base/memory/scoped_vector...
base/memory/scoped_vector_unittest.cc:120: EXPECT_TRUE(scoped_vector.empty());
And actually, no need for any cast at all here.

[willchan no longer on Chromium, 2012-12-04 01:42:50]

lgtm

[commit-bot: I haz the power, 2012-12-04 01:44:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/11416166/13003

[commit-bot: I haz the power, 2012-12-04 04:49:25]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 19:10:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/11416166/13003

[commit-bot: I haz the power, 2012-12-04 21:51:45]

Change committed as 171058