sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 11416144: Produce run-time error when type parameters are accessed from static context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11416144: Produce run-time error when type parameters are accessed from static context. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Removed redundant malformed type replacement with dynamic type. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('j') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index 8ed02f216a651145c5214b78c7bee81d36b416e6..63e14f98b8b68d83ea3b786189df6a695c5516bf 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -365,7 +365,8 @@ class PlaceholderCollector extends Visitor {

Element constructor = treeElements[send];

assert(constructor != null);

assert(send.receiver == null);

- if (constructor is !ErroneousElement) {

+ if (!Elements.isErroneousElement(constructor) &&

ngeoffray 2012/11/27 09:37:35 Can that be !Elements.isUnresolved(constructor) ?

aam-me 2012/11/28 01:49:47 Yes, good idea!

+ !Elements.isMalformedElement(constructor)) {

makeConstructorPlaceholder(node.send.selector, constructor, type);

// TODO(smok): Should this be in visitNamedArgument?

// Field names can be exposed as names of optional arguments, e.g.