Produce run-time error when type parameters are accessed from static context.

sdk/lib/_internal/compiler/implementation/typechecker.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 class TypeCheckerTask extends CompilerTask {
   TypeCheckerTask(Compiler compiler) : super(compiler);
   String get name => "Type checker";
 
@@ skipping 18 matching lines @@
 class TypeKind {
   final String id;
 
   const TypeKind(String this.id);
 
   static const TypeKind FUNCTION = const TypeKind('function');
   static const TypeKind INTERFACE = const TypeKind('interface');
   static const TypeKind STATEMENT = const TypeKind('statement');
   static const TypeKind TYPEDEF = const TypeKind('typedef');
   static const TypeKind TYPE_VARIABLE = const TypeKind('type variable');
+  static const TypeKind MALFORMED_TYPE = const TypeKind('malformed');
   static const TypeKind VOID = const TypeKind('void');
 
   String toString() => id;
 }
 
 abstract class DartType {
   SourceString get name;
 
   TypeKind get kind;
 
@@ skipping 94 matching lines @@
 
   DartType unalias(Compiler compiler) => this;
 
   int get hashCode => 1729;
 
   bool operator ==(other) => other is VoidType;
 
   String toString() => name.slowToString();
 }
 
+class MalformedType extends DartType {
+  const MalformedType(this.element);
+
+  TypeKind get kind => TypeKind.MALFORMED_TYPE;
+
+  SourceString get name => element.name;
+
+  final MalformedTypeElement element;
+
+  DartType unalias(Compiler compiler) => this;
+
+  int get hashCode => 1733;
+
+  bool operator ==(other) => other is MalformedType;

[ngeoffray, 2012/11/27 09:37:35]

Not checking if elements are equal is kind of strange. Could you add a comment?

[aam-me, 2012/11/28 01:49:47]

Good point. I used VoidType above as a template.

But it makes sense to change it to something like this:
  bool operator ==(other) {
    if (other is !MalformedType) return false;
    if (!identical(element, other.element)) return false;
    return true;
  }

+
+  String toString() => name.slowToString();
+}
+
 class InterfaceType extends DartType {
   final Element element;
   final Link<DartType> arguments;
 
   InterfaceType(this.element,
                 [this.arguments = const Link<DartType>()]) {
     assert(invariant(element, element.isDeclaration));
   }
 
   TypeKind get kind => TypeKind.INTERFACE;
@@ skipping 151 matching lines @@
         identical(s, dynamicType) ||
         identical(s.element, compiler.objectClass) ||
         identical(t.element, compiler.nullClass)) {
       return true;
     }
     t = t.unalias(compiler);
     s = s.unalias(compiler);
 
     if (t is VoidType) {
       return false;
+    } else if (t is MalformedType) {
+      return false;
     } else if (t is InterfaceType) {
       if (s is !InterfaceType) return false;
       ClassElement tc = t.element;
       if (identical(tc, s.element)) return true;
       for (Link<DartType> supertypes = tc.allSupertypes;
            supertypes != null && !supertypes.isEmpty;
            supertypes = supertypes.tail) {
         DartType supertype = supertypes.head;
         if (identical(supertype.element, s.element)) return true;
       }
@@ skipping 698 matching lines @@
   }
 
   DartType visitStringNode(StringNode node) {
     compiler.unimplemented('visitNode', node: node);
   }
 
   DartType visitLibraryDependency(LibraryDependency node) {
     compiler.unimplemented('visitNode', node: node);
   }
 }