Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11416133: Moved buffer handling to AssemblerBase. (Closed)

Created:
8 years, 1 month ago by Sven Panne
Modified:
8 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Moved buffer handling to AssemblerBase. This removed a lot of copy-n-paste code and is very handy for some upcoming changes (regarding predictable code size). Committed: https://code.google.com/p/v8/source/detail?r=13034

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -229 lines) Patch
M src/arm/assembler-arm.h View 4 chunks +1 line, -11 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +3 lines, -44 lines 0 comments Download
M src/assembler.h View 2 chunks +16 lines, -1 line 0 comments Download
M src/assembler.cc View 2 chunks +35 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 4 chunks +1 line, -12 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +4 lines, -44 lines 0 comments Download
M src/mips/assembler-mips.h View 4 chunks +1 line, -11 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +3 lines, -48 lines 0 comments Download
M src/x64/assembler-x64.h View 4 chunks +1 line, -12 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -45 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 1 month ago (2012-11-21 14:45:15 UTC) #1
Toon Verwaest
8 years, 1 month ago (2012-11-22 09:48:13 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698