Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 11416127: Android WebView: makefiles are host_os-specific. (Closed)

Created:
8 years, 1 month ago by Torne
Modified:
8 years, 1 month ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, pam+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Android WebView: makefiles are host_os-specific. The generated makefiles are specific to the host OS they were generated for. For now, just name them appropriately so that mac hosts don't try to include linux-specific makefiles. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Android.mk View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/tools/gyp_webview View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Torne
8 years, 1 month ago (2012-11-21 11:52:06 UTC) #1
mkosiba (inactive)
8 years, 1 month ago (2012-11-21 12:13:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698